file: add file_system_space #2597
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikivity
reviewed
Dec 23, 2024
avikivity
reviewed
Dec 23, 2024
include/seastar/core/file-types.hh
Outdated
| @@ -158,6 +159,18 @@ inline constexpr file_permissions operator&(file_permissions a, file_permissions | |||
| return file_permissions(std::underlying_type_t<file_permissions>(a) & std::underlying_type_t<file_permissions>(b)); | |||
| } | |||
|
|
|||
| /// seastar::space_info is equivalent to std::filesystem::space_info | |||
| /// with renamed members, to prevent a conflict with future::available() | |||
| struct space_info { | |||
There was a problem hiding this comment.
Why not use std::filesystem::space_info?
There was a problem hiding this comment.
I mentioned it in a comment.
The compiler complains about it due to the available member conflicting with future::available. I can reproduce and quote the error
There was a problem hiding this comment.
How can it conflict with future::available? It's in a different class.
There was a problem hiding this comment.
v2 is rebased onto #2598 for now
avikivity
reviewed
Dec 23, 2024
avikivity
reviewed
Dec 23, 2024
| }; | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Please use coroutines in new code.
avikivity
reviewed
Dec 23, 2024
bhalevy
force-pushed
the
filesystem-space
branch
from
c59710c to
d9b772b
Compare
|
Draft until #2598 |
|
In v2 (cf0b6a5):
|
bhalevy
force-pushed
the
filesystem-space
branch
from
d9b772b to
cf0b6a5
Compare
Return space_info for the filesystem identified by the given file name. space_info provides simpler and standard space information about the filesystem, in contrast to the posix statvfs which requires knowledge about the how to convert f_block to bytes by multiplying by f_frsize. Signed-off-by: Benny Halevy <[email protected]>
bhalevy
force-pushed
the
filesystem-space
branch
from
cf0b6a5 to
c80e451
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return space_info for the filesystem identified
by the given file name.
space_info provides simpler and standard space information about the filesystem, in contrast to the posix statvfs which requires knowledge about the how to convert
f_block to bytes by multiplying by f_frsize.